linux-kernel - Re: Re: [PATCH] bitmap: Add bitmap_valloc(), bitmap_vzalloc() and bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Dec 2018 11:11:46 +0800 (GMT+08:00)
From:   王鹏 <rocking@....edu.cn>
To:     "andrew morton" <akpm@...ux-foundation.org>
Cc:     andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk,
        ynorov@...iumnetworks.com, arnd@...db.de, courbet@...gle.com,
        osandov@...com, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] bitmap: Add bitmap_valloc(), bitmap_vzalloc() and
 bitmap_vfree()

On Date: Fri, 28 Dec 2018 15:41:37 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> From: "Andrew Morton" <akpm@...ux-foundation.org>
> Sent Time: 2018-12-29 07:41:37 (Saturday)
> To: "Peng Wang" <rocking@....edu.cn>
> Cc: andriy.shevchenko@...ux.intel.com, linux@...musvillemoes.dk, ynorov@...iumnetworks.com, arnd@...db.de, courbet@...gle.com, osandov@...com, linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] bitmap: Add bitmap_valloc(), bitmap_vzalloc() and bitmap_vfree()
> 
> On Fri, 28 Dec 2018 00:18:29 +0800 Peng Wang <rocking@....edu.cn> wrote:
> 
> > Introduce bitmap alloc/free helpers when contiguous
> > memory is not necessary.
> 
> That's a large bitmap you have there.  What code needs this?

Hi Andrew,
Not only for large bitmap. This can also benefit from high memory pressure with no requirement for physical continuousness.

While these two casees are rather rare. And I only find one place in mm/swapfile.c.

3224         /* frontswap enabled? set up bit-per-page map for frontswap */
3225         if (IS_ENABLED(CONFIG_FRONTSWAP))
3226                 frontswap_map = kvcalloc(BITS_TO_LONGS(maxpages),
3227                                          sizeof(long),
3228                                          GFP_KERNEL);

I am not sure whether these helper functions can gain as much benefits as the efforts to introduce them.

Cheers,
Peng