linux-kernel - Re: [PATCH] isdn: hisax: hfc_pci: Fix a possible concurrency use-after-free bug in HFCPCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181228.212751.1498034981468762216.davem@davemloft.net>
Date:   Fri, 28 Dec 2018 21:27:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@...il.com
Cc:     isdn@...ux-pingi.de, natechancellor@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: hisax: hfc_pci: Fix a possible concurrency
 use-after-free bug in HFCPCI_l1hw()

From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Wed, 26 Dec 2018 22:09:34 +0800

> In drivers/isdn/hisax/hfc_pci.c, the functions hfcpci_interrupt() and
> HFCPCI_l1hw() may be concurrently executed.
> 
> HFCPCI_l1hw()
>   line 1173: if (!cs->tx_skb)
> 
> hfcpci_interrupt()
>   line 942: spin_lock_irqsave();
>   line 1066: dev_kfree_skb_irq(cs->tx_skb);
> 
> Thus, a possible concurrency use-after-free bug may occur 
> in HFCPCI_l1hw().
> 
> To fix these bugs, the calls to spin_lock_irqsave() and
> spin_unlock_irqrestore() are added in HFCPCI_l1hw(), to protect the
> access to cs->tx_skb.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied.