linux-kernel - Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9iUCPqqyK7KMvchM4jY_FBgujnQm019J27TpDJjXUXvu5sjQ@mail.gmail.com>
Date:   Sun, 30 Dec 2018 21:56:53 +0300
From:   Sinan Kaya <Okaya@...nel.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>, faiz_abbas@...com,
        chunyan.zhang@...soc.com, Jisheng.Zhang@...aptics.com,
        ludovic.barre@...com, Arnd Bergmann <arnd@...db.de>,
        alex.smith@...tec.com, chris.brandt@...esas.com,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 09/11] mmc: add PCI dependency into IOSF_MBI

On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@...nel.org> wrote:
> >
> > Select IOSF_MBI only when PCI is set.
> >
> > Signed-off-by: Sinan Kaya <okaya@...nel.org>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index e26b8145efb3..4c5f037b246d 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -117,7 +117,7 @@ config MMC_RICOH_MMC
> >  config MMC_SDHCI_ACPI
> >         tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> >         depends on MMC_SDHCI && ACPI
>
> It should depend on PCI as well, shouldn't it?
>

I don't think so. The PCI dependency is at IOSF_MBI code so code
should select IOSF_MBI only when x86 and pci is defined as below.

This driver does not depend on PCI.

> As it stands with the patch applied, randconfig can still select it if
> PCI is unset AFAICS, can't it?

True, we also should be careful about separating ACPI from PCI.
Someone should be able to define a sdhci acpi object without PCI.

What do you think about this?

>
> > -       select IOSF_MBI if X86
> > +       select IOSF_MBI if (X86 && PCI)
> >         help
> >           This selects support for ACPI enumerated SDHCI controllers,
> >           identified by ACPI Compatibility ID PNP0D40 or specific
> > --