linux-kernel - Re: [PATCH v2] ipv4: fib_rules: Fix possible infinite loop in fib_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181230.125722.160476917983481656.davem@davemloft.net>
Date:   Sun, 30 Dec 2018 12:57:22 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] ipv4: fib_rules: Fix possible infinite loop in
 fib_empty_table

From: YueHaibing <yuehaibing@...wei.com>
Date: Sat, 29 Dec 2018 14:45:23 +0800

> gcc warn this:
> net/ipv4/fib_rules.c:203 fib_empty_table() warn:
>  always true condition '(id <= 4294967295) => (0-u32max <= u32max)'
> 
> 'id' is u32, which always not greater than RT_TABLE_MAX
> (0xFFFFFFFF), So add a check to break while wrap around.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: clean up exit conditions

Applied.