linux-kernel - Re: [PATCH] x86/asm: Use CC_SET/CC_OUT in percpu_cmpxchg16b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFULd4apcgrNMNhkX-NsdRSi3KyHg+z+eZtdbeXAj6RYPeM7Zg@mail.gmail.com>
Date:   Sun, 30 Dec 2018 12:07:13 +0100
From:   Uros Bizjak <ubizjak@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Uros Bizjak <ubizjak@...il.com>, x86@...nel.org
Subject: Re: [PATCH] x86/asm: Use CC_SET/CC_OUT in percpu_cmpxchg16b_double

On 12/28/18, Uros Bizjak <ubizjak@...il.com> wrote:
> Use CC_SET(z)/CC_OUT(z) instead of explicit setz instruction.
> Using these two defines, the compiler that supports generation of
> condition code outputs from inline assembly flags generates one
> conditional jump instruction, e.g:

Unfortunatelly, the 0day kernel test robot reports:

[    1.569154] DEBUG_LOCKS_WARN_ON(unlikely(early_boot_irqs_disabled))
[    1.569287] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:2803
lockdep_hardirqs_on+0xc5/0x19e

presumably due to unconditional interrupt enable in
this_cpu_cmpxchg16b_emu. I have to somehow disable X86_FATURE_CX16 and
thoroughly test the library path.

Uros.