linux-kernel - Re: [GIT PULL] sound updates for 4.21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgDKUQthwqe_RYm1=uJBKLvGQO9-90BNkO6rE-Ck7hVwQ@mail.gmail.com>
Date:   Sun, 30 Dec 2018 16:19:31 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Takashi Iwai <tiwai@...e.de>, Ingo Molnar <mingo@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] sound updates for 4.21

On Sun, Dec 30, 2018 at 3:18 PM Pierre-Louis Bossart
<pierre-louis.bossart@...ux.intel.com> wrote:
>
> The KabyLake Dell XPS13 was initially used for the ASoC driver for
> HDaudio, so there is no known hardware-related reason why this problem
> happens.

Mine isn't the Kabylake one, it's the older XPS13 9350 (2015 - Skylake) one.

> The simplest way to make the problem go away is to force the legacy
> driver to bind with the (untested) diff below.

That diff is wrong, since it changes the meaning of the binding
numbers, but then the module interface is wrong:

   static int skl_pci_binding;
   module_param_named(pci_binding, skl_pci_binding, int, 0444);
   MODULE_PARM_DESC(pci_binding, "PCI binding (0=auto, 1=only legacy,
2=only asoc");

so I think Takashi's patch to just change the default value of
skl_pci_binding is the better one.

                Linus