linux-kernel - Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Dec 2018 11:43:32 -0800
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Joey Pabalinas <joeypabalinas@...il.com>, Willy Tarreau <w@....eu>,
        mingo@...nel.org, rdunlap@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] rcutorture/nolibc: fix some poor indentation and
 alignment

On Sat, Dec 29, 2018 at 12:30:33PM -1000, Joey Pabalinas wrote:
> On Sat, Dec 29, 2018 at 07:02:17PM +0100, Willy Tarreau wrote:
> > A few macros had their rightmost backslash misaligned, and the pollfd
> > struct definition resisted the previous code reindent. Nothing else
> > changed.
> > 
> > Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> > Signed-off-by: Willy Tarreau <w@....eu>
> 
> Reviewed-by: Joey Pabalinas <joeypabalinas@...il.com>

Applied, thank you both!

							Thanx, Paul

> > ---
> >  tools/testing/selftests/rcutorture/bin/nolibc.h | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/rcutorture/bin/nolibc.h b/tools/testing/selftests/rcutorture/bin/nolibc.h
> > index 30bd27b..985364c 100644
> > --- a/tools/testing/selftests/rcutorture/bin/nolibc.h
> > +++ b/tools/testing/selftests/rcutorture/bin/nolibc.h
> > @@ -81,9 +81,9 @@ typedef   signed long        time_t;
> >  
> >  /* for poll() */
> >  struct pollfd {
> > -    int fd;
> > -    short int events;
> > -    short int revents;
> > +	int fd;
> > +	short int events;
> > +	short int revents;
> >  };
> >  
> >  /* for select() */
> > @@ -239,7 +239,7 @@ struct stat {
> >  		"syscall\n"                                                   \
> >  		: "=a" (_ret)                                                 \
> >  		: "0"(_num)                                                   \
> > -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> > +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
> >  	);                                                                    \
> >  	_ret;                                                                 \
> >  })
> > @@ -255,7 +255,7 @@ struct stat {
> >  		: "=a" (_ret)                                                 \
> >  		: "r"(_arg1),                                                 \
> >  		  "0"(_num)                                                   \
> > -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> > +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
> >  	);                                                                    \
> >  	_ret;                                                                 \
> >  })
> > @@ -272,7 +272,7 @@ struct stat {
> >  		: "=a" (_ret)                                                 \
> >  		: "r"(_arg1), "r"(_arg2),                                     \
> >  		  "0"(_num)                                                   \
> > -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> > +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
> >  	);                                                                    \
> >  	_ret;                                                                 \
> >  })
> > @@ -290,7 +290,7 @@ struct stat {
> >  		: "=a" (_ret)                                                 \
> >  		: "r"(_arg1), "r"(_arg2), "r"(_arg3),                         \
> >  		  "0"(_num)                                                   \
> > -		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"                                \
> > +		: "rcx", "r8", "r9", "r10", "r11", "memory", "cc"             \
> >  	);                                                                    \
> >  	_ret;                                                                 \
> >  })
> > -- 
> > 2.9.0
> > 
> 
> -- 
> Cheers,
> Joey Pabalinas