linux-kernel - Re: [PATCH net] net: hns3: call hns3_nic_net_open() while doing HNAE3_UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 01 Jan 2019 12:14:33 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, mehta.salil@...src.net
Subject: Re: [PATCH net] net: hns3: call hns3_nic_net_open() while doing
 HNAE3_UP_CLIENT

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Mon, 31 Dec 2018 10:58:29 +0800

> For HNAE3_DOWN_CLIENT calling hns3_nic_net_stop(), HNAE3_UP_CLIENT
> should call hns3_nic_net_open(), since if the number of queue or
> the map of TC has is changed before HHAE3_UP_CLIENT is called,
> it will cause problem.
> 
> Also the HNS3_NIC_STATE_RESETTING flag needs to be cleared before
> hns3_nic_net_open() called, and set it back while hns3_nic_net_open()
> failed.
> 
> Fixes: bb6b94a896d4 ("net: hns3: Add reset interface implementation in client")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Peng Li <lipeng321@...wei.com>

Applied and queued up for -stable.