linux-kernel - Re: [PATCH] line6: add a check for snd_card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 01 Jan 2019 10:00:07 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Kangjie Lu" <kjlu@....edu>
Cc:     <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <pakki001@....edu>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] line6: add a  check for snd_card_register

On Wed, 26 Dec 2018 04:39:31 +0100,
Kangjie Lu wrote:
> 
> The fix checks if snd_card_register() fails, and if so, issues a
> warning.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

Hmm, you submitted multiple patches doing the similar things but the
error messages are handled completely differently in both cases.
Please make them consistent.

... and above all:

> -	snd_card_register(line6->card);
> +	if (snd_card_register(line6->card))
> +		pr_warn("Failed to register ALSA card.\n");

This error message is almost useless.  Better to use dev_*() variant.


thanks,

Takashi