linux-kernel - Re: [PATCH] fsi:fsi-sbefifo: Fix possible concurrency use-after-free bugs in sbefifo_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26864.1546421693@warthog.procyon.org.uk>
Date:   Wed, 02 Jan 2019 09:34:53 +0000
From:   David Howells <dhowells@...hat.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     dhowells@...hat.com, benh@...nel.crashing.org, joel@....id.au,
        eajames@...ux.vnet.ibm.com, andrew@...id.au,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi:fsi-sbefifo: Fix possible concurrency use-after-free bugs in sbefifo_user_release

Jia-Ju Bai <baijiaju1990@...il.com> wrote:

> +	mutex_lock(&user->file_lock);
>  	sbefifo_release_command(user);
>  	free_page((unsigned long)user->cmd_page);
> +	mutex_unlock(&user->file_lock);

It shouldn't be necessary to do the free_page() call inside the locked
section.

David