linux-kernel - Re: [PATCH] debugfs: debugfs_use_start/finish do not exist anymore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iCmGaVXwOZwKo9k_vFamiY7E8jNyCFykrLsFnXbo0-nQ@mail.gmail.com>
Date:   Wed, 2 Jan 2019 10:41:55 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] debugfs: debugfs_use_start/finish do not exist anymore

On Sun, Dec 30, 2018 at 4:49 AM Sergey Senozhatsky
<sergey.senozhatsky@...il.com> wrote:
>
> debugfs_use_file_start() and debugfs_use_file_finish() do not exist
> since commit c9afbec27089 ("debugfs: purge obsolete SRCU based removal
> protection"); tweak debugfs_create_file_unsafe() comment.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  fs/debugfs/inode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 13b01351dd1c..4354069101b4 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -422,8 +422,8 @@ EXPORT_SYMBOL_GPL(debugfs_create_file);
>   * debugfs core.
>   *
>   * It is your responsibility to protect your struct file_operation
> - * methods against file removals by means of debugfs_use_file_start()
> - * and debugfs_use_file_finish(). ->open() is still protected by
> + * methods against file removals by means of debugfs_file_get()
> + * and debugfs_file_put(). ->open() is still protected by
>   * debugfs though.
>   *
>   * Any struct file_operations defined by means of
> --
> 2.20.1
>