linux-kernel - Re: [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190102094620.GE3781@kadam>
Date:   Wed, 2 Jan 2019 01:46:20 -0800 (PST)
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Prathamesh Deshpande <prathameshdeshpande7@...il.com>
Cc:     osdevtc@...il.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: prism2fw.c: Fix "Possible unnecessary
 'out of memory' message" checkpatch.pl warning"

The subject is too long.

On Mon, Dec 24, 2018 at 08:11:28AM -0800, Prathamesh Deshpande wrote:
> This patch removes unnecessary out of memory warning
> message from wlan-ng prism2fw.c file.
> 
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@...il.com>
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> index bb572b7..c040066 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -557,7 +557,6 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt)
>  	for (i = 0; i < *ccnt; i++) {
>  		clist[i].data = kzalloc(clist[i].len, GFP_KERNEL);
>  		if (!clist[i].data) {
> -			pr_err("failed to allocate image space, exiting.\n");
>  			return 1;
>  		}

Remove the curly braces.

regards,
dan carpenter