lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 2 Jan 2019 11:05:12 +0100
From:   Geert Uytterhoeven <>
To:     Arnd Bergmann <>
Cc:     netdev <>,
        "Acked-by : Phil Sutter" <>,
        Thomas Graf <>,
        Herbert Xu <>,
        "David S. Miller" <>,
        NeilBrown <>,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH] [v2] test_rhashtable: remove semaphore usage

Hi Arnd,

On Sun, Dec 16, 2018 at 8:50 PM Arnd Bergmann <> wrote:
> This is one of only two files that initialize a semaphore to a negative
> value. We don't really need the two semaphores here at all, but can do
> the same thing in more conventional and more effient way, by using a
> single waitqueue and an atomic thread counter.
> This gets us a little bit closer to eliminating classic semaphores from
> the kernel. It also fixes a corner case where we fail to continue after
> one of the threads fails to start up.
> An alternative would be to use a split kthread_create()+wake_up_process()
> and completely eliminate the separate synchronization.
> Acked-by: Phil Sutter <>
> Signed-off-by: Arnd Bergmann <>
> ---
> Changes from v1:
>  - rebase to mainline,
>  - fix pr_err() output
>  - bail out if interrupted

Now this is upstream as 809c67059162e7ba ("test_rhashtable: remove
semaphore usage"), I gave test_rhashtable a try again on m68k/ARAnyM.
And it succeeded, without my workaround from
Interestingly, it still succeeded without the workaround after reverting
809c67059162e7ba, so some other change during the last two years must
have fixed this.

I have no plans to bisect this, though.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists