linux-kernel - Re: [PATCH] staging: rts5208: Add a check for ms_read_extra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190102105058.GH3781@kadam>
Date:   Wed, 2 Jan 2019 13:50:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aditya Pakki <pakki001@....edu>
Cc:     devel@...verdev.osuosl.org, Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>, kjlu@....edu,
        linux-kernel@...r.kernel.org, Aymen Qader <qader.aymen@...il.com>
Subject: Re: [PATCH] staging: rts5208: Add a check for ms_read_extra_data

On Thu, Dec 27, 2018 at 01:35:53PM -0600, Aditya Pakki wrote:
> In ms_copy_page, the function ms_read_extra_data may fail for many
> reasons. The fix adds a check similar to other invocation to return
> error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>

Yup.  It doesn't make sense to use stale "extra" data. 

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter