linux-kernel - Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190102105531.GI3781@kadam>
Date:   Wed, 2 Jan 2019 13:55:31 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     YueHaibing <yuehaibing@...wei.com>,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...capital.net>,
        Will Drewry <wad@...omium.org>,
        Marcos Paulo de Souza <marcos.souza.org@...il.com>,
        David Windsor <dave@...lcore.net>,
        Roman Gushchin <guro@...com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Rik van Riel <riel@...riel.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] mm: Mark 'stack_vm_area' with __maybe_unused

On Fri, Dec 28, 2018 at 09:58:04AM +0100, Michal Hocko wrote:
> On Fri 28-12-18 02:46:30, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning when
> > CONFIG_VMAP_STACK is not set:
> 
> Isn't this warning disabled? I can see the following
> # These warnings generated too much noise in a regular build.
> # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
> KBUILD_CFLAGS += -Wno-unused-but-set-variable
> 
> in the main makefile. IMHO this warning doesn't really give us much.
> 

It would be nice to enable that warning.  YueHaibing and Colin King have
been whittling away at the problematic code...

YueHaibing, how many of these warnings do we have remaining on an
allmodoconfig?

regards,
dan carpenter