linux-kernel - Re: [PATCH 11/20] Btrfs: drop useless LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190102164048.GZ23615@twin.jikos.cz>
Date:   Wed, 2 Jan 2019 17:40:48 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Chris Mason <clm@...com>, kernel-janitors@...r.kernel.org,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/20] Btrfs: drop useless LIST_HEAD

On Sun, Dec 23, 2018 at 09:57:06AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> The uses were removed in 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC
> handling for balance"), but not the declaration.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // </smpl>
> 
> Fixes: 3fd0a5585eb9 ("Btrfs: Metadata ENOSPC handling for balance")
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Added to patch queue, thanks. I've dropepd the Fixes: line as it's not
really a fix that would need to go to stable. The original commit is
mentioned in the changelog which is IMHO sufficient.