linux-kernel - Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Jan 2019 22:35:35 +0300
From:   Ivan Safonov <insafonov@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        Michael Straube <straube.linux@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"

On 1/2/19 4:06 AM, Larry Finger wrote:
> On 1/1/19 1:31 PM, Michael Straube wrote:
>>
>> I've tested your patch and it solved the issue. No freezes and dmesg 
>> looks good.
>>
>> I noticed that try_then_request_module() is also used in 
>> rtw_wep_encrypt() and
>> rtw_wep_decrypt(). I guess that also could cause problems?
> 
> Yes, I believe it would if anyone is still using WEP. My plan is to get 
> rid of the try_then_request_module() there as well, and for 
> completeness, I plan to restore usage of the lib80211 routines for TKIP 
> as well.

Patch "load lib80211 crypto ops from interruptible context" ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html 
) is a preparation to replace
     crypto_ops = try_then_request_module(lib80211_get_crypto_ops(*), 
"lib80211_crypt_*");
with
     (struct crypto_algorithm).ops

> 
> Once I get a chance to test the TKIP and WEP changes, I plan to have a 
> set of 4 patches to switch the driver to using lib80211 routines for all 
> decryption/encryption.


There are four other patches to use lib80211:
use lib80211 CCMP decrypt ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-February/116533.html 
)
Use lib80211 to encrypt (WEP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/122642.html 
)
Use lib80211 to encrypt (TKIP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123249.html 
)
Use lib80211 to encrypt (CCMP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123250.html 
)

They all crash when try_then_request_module() called.

> 
> Larry
> 
>