linux-kernel - Re: [PATCH v2] thermal: tsens: qcom: do not create duplicate regmap debugfs entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190102033240.GA22852@builder>
Date:   Tue, 1 Jan 2019 19:32:40 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     amit.kucheria@...aro.org, edubezval@...il.com,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, daniel.lezcano@...aro.org
Subject: Re: [PATCH v2] thermal: tsens: qcom: do not create duplicate regmap
 debugfs entries

On Thu 06 Dec 01:39 PST 2018, Srinivas Kandagatla wrote:

> Regmap would use device name to create debugfs entries. If the device
> has multiple regmaps it is recommended to use name field in regmap_config.
> Fix this by providing name to the regmap configs correctly.
> 
> Without this patch we would see below error on DB820c.
> 
> qcom-tsens 4a9000.thermal-sensor: Failed to create 4a9000.thermal-sensor
> debugfs directory
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Acked-by: Amit Kucheria <amit.kucheria@...aro.org>
> Tested-by: Amit Kucheria <amit.kucheria@...aro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
> Changes since v1:
>  -rename tsens_config to tsens_tm_config as suggested by Amit.
> 
>  drivers/thermal/qcom/tsens-common.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 3be4be2e0465..ddfdf88ffb4e 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -113,7 +113,15 @@ int get_temp_common(struct tsens_device *tmdev, int id, int *temp)
>  	return 0;
>  }
>  
> -static const struct regmap_config tsens_config = {
> +static const struct regmap_config tsens_tm_config = {
> +	.name		= "tm",
> +	.reg_bits	= 32,
> +	.val_bits	= 32,
> +	.reg_stride	= 4,
> +};
> +
> +static const struct regmap_config tsens_srot_config = {
> +	.name		= "srot",
>  	.reg_bits	= 32,
>  	.val_bits	= 32,
>  	.reg_stride	= 4,
> @@ -139,8 +147,8 @@ int __init init_common(struct tsens_device *tmdev)
>  		if (IS_ERR(srot_base))
>  			return PTR_ERR(srot_base);
>  
> -		tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev,
> -							srot_base, &tsens_config);
> +		tmdev->srot_map = devm_regmap_init_mmio(tmdev->dev, srot_base,
> +							&tsens_srot_config);
>  		if (IS_ERR(tmdev->srot_map))
>  			return PTR_ERR(tmdev->srot_map);
>  
> @@ -154,7 +162,8 @@ int __init init_common(struct tsens_device *tmdev)
>  	if (IS_ERR(tm_base))
>  		return PTR_ERR(tm_base);
>  
> -	tmdev->tm_map = devm_regmap_init_mmio(tmdev->dev, tm_base, &tsens_config);
> +	tmdev->tm_map = devm_regmap_init_mmio(tmdev->dev, tm_base,
> +						 &tsens_tm_config);
>  	if (IS_ERR(tmdev->tm_map))
>  		return PTR_ERR(tmdev->tm_map);
>  
> -- 
> 2.19.2
>