linux-kernel - Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLXz_s6B=NzSp17Lj6xMTYybEsMh4jDR8COXnWQCnFTrsw@mail.gmail.com>
Date:   Wed, 2 Jan 2019 14:21:01 -0800
From:   John Stultz <john.stultz@...aro.org>
To:     Jan Kiszka <jan.kiszka@....de>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Wei Xu <xuwei5@...ilicon.com>, Ryan Grachek <ryan@...ted.us>,
        linux-wireless@...r.kernel.org, "Reizer, Eyal" <eyalr@...com>,
        Valentin Schneider <valentin.schneider@....com>,
        Tony Lindgren <tony@...mide.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        KISHON VIJAY ABRAHAM <kishon@...com>,
        "Mishol, Guy" <guym@...com>,
        Anders Roxell <anders.roxell@...aro.org>,
        Ricardo Salveti <rsalveti@...lveti.net>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on

Adding a few folks to cc from the thread here:
https://patchwork.kernel.org/patch/10734021/

As this sounds like a very similar issue.
thanks
-john

On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@....de> wrote:
>
> From: Jan Kiszka <jan.kiszka@...mens.com>
>
> Somewhere along recent changes to power control of the wl1835, power-on
> became very unreliable on the hikey, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms, the
> hikey is already very happy with 1 ms.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
>
> Tested with 4.19 and linus/master.
>
>   arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index f4964bee6a1a..1e771bf201b9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -118,6 +118,7 @@
>                 reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>                 clocks = <&pmic>;
>                 clock-names = "ext_clock";
> +               post-power-on-delay-ms = <1>;
>                 power-off-delay-us = <10>;
>         };
>
> --
> 2.16.4