linux-kernel - Re: [PATCH v1] phy: qcom-ufs: Use iopoll.h readl_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iHTCXutb2x+-11Skz=8159t9v=_POaLuoYpt3NsWuwe3A@mail.gmail.com>
Date:   Wed, 2 Jan 2019 12:23:25 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Marc Gonzalez <marc.w.gonzalez@...e.fr>
Cc:     Kishon Vijay Abraham <kishon@...com>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Yaniv Gardi <ygardi@...eaurora.org>,
        Matt Wagantall <mattw@...eaurora.org>,
        Mitchel Humpherys <mitchelh@...eaurora.org>,
        Will Deacon <will.deacon@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        MSM <linux-arm-msm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] phy: qcom-ufs: Use iopoll.h readl_poll_timeout macro

On Fri, Dec 21, 2018 at 9:43 PM Marc Gonzalez <marc.w.gonzalez@...e.fr> wrote:
>
> The private copy of readl_poll_timeout is no longer needed.
> Use the implementation in iopoll.h instead.
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@...e.fr>
> ---
>  drivers/phy/qualcomm/phy-qcom-ufs-i.h | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs-i.h b/drivers/phy/qualcomm/phy-qcom-ufs-i.h
> index 681644e43248..f798fb64de94 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs-i.h
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs-i.h
> @@ -23,24 +23,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/io.h>
>  #include <linux/delay.h>
> -
> -#define readl_poll_timeout(addr, val, cond, sleep_us, timeout_us) \
> -({ \
> -       ktime_t timeout = ktime_add_us(ktime_get(), timeout_us); \
> -       might_sleep_if(timeout_us); \
> -       for (;;) { \
> -               (val) = readl(addr); \
> -               if (cond) \
> -                       break; \
> -               if (timeout_us && ktime_compare(ktime_get(), timeout) > 0) { \
> -                       (val) = readl(addr); \
> -                       break; \
> -               } \
> -               if (sleep_us) \
> -                       usleep_range(DIV_ROUND_UP(sleep_us, 4), sleep_us); \
> -       } \
> -       (cond) ? 0 : -ETIMEDOUT; \
> -})
> +#include <linux/iopoll.h>
>
>  #define UFS_QCOM_PHY_CAL_ENTRY(reg, val)       \
>         {                               \
> --
> 2.17.1

Thanks for the patch. LGTM.
Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

Best regards
Vivek

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation