linux-kernel - Re: [PATCH] kbuild: use assignment instead of define ... endef for filechk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190103073652.GA3957@osiris>
Date:   Thu, 3 Jan 2019 08:36:52 +0100
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Michal Marek <michal.lkml@...kovi.net>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
Subject: Re: [PATCH] kbuild: use assignment instead of define ... endef for
 filechk_* rules

On Thu, Jan 03, 2019 at 10:16:54AM +0900, Masahiro Yamada wrote:
> You do not have to use define ... endef for filechk_* rules.
> 
> For simple cases, the use of assignment looks cleaner, IMHO.
> 
> I updated the usage for scripts/Kbuild.include in case somebody
> misunderstands the 'define ... endif' is the requirement.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  Kbuild                             |  4 +---
>  Makefile                           |  3 +--
>  arch/s390/kernel/syscalls/Makefile | 12 +++---------
>  arch/s390/tools/Makefile           |  7 ++-----
>  scripts/Kbuild.include             |  8 ++++----
>  scripts/kconfig/Makefile           |  4 +---
>  6 files changed, 12 insertions(+), 26 deletions(-)

For the s390 bits:
Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>