linux-kernel - Re: [PATCH] irqchip/gic-v3: use _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c4d154b-037d-25a0-7dad-7d2c80a252f9@arm.com>
Date:   Thu, 3 Jan 2019 11:08:00 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Stefan Agner <stefan@...er.ch>, tglx@...utronix.de,
        jason@...edaemon.net
Cc:     linux-kernel@...r.kernel.org,
        linux-arm-kernel-bounces@...ts.infradead.org
Subject: Re: [PATCH] irqchip/gic-v3: use __init where appropriate

Hi Stephan,

On 29/12/2018 14:14, Stefan Agner wrote:
> Compiling with section mismatch debugging enabled prints the
> following warning:
>   WARNING: vmlinux.o(.text+0xffa1b8): Section mismatch in reference from
>   the function gic_smp_init() to the function .init.text:set_smp_cross_call()
> 
> Avoid this warning by adding __init to gic_smp_init(). While add it,
> also add it where appropriate.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
>  drivers/irqchip/irq-gic-v3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 0868a9d81c3c..3b33c94041e5 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -768,7 +768,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
>  	isb();
>  }
>  
> -static void gic_smp_init(void)
> +static void __init gic_smp_init(void)
>  {
>  	set_smp_cross_call(gic_raise_softirq);
>  	cpuhp_setup_state_nocalls(CPUHP_AP_IRQ_GIC_STARTING,
> @@ -848,7 +848,7 @@ static struct notifier_block gic_cpu_pm_notifier_block = {
>  	.notifier_call = gic_cpu_pm_notifier,
>  };
>  
> -static void gic_cpu_pm_init(void)
> +static void __init gic_cpu_pm_init(void)
>  {
>  	cpu_pm_register_notifier(&gic_cpu_pm_notifier_block);
>  }
> 

Interesting. I don't see this warning at all. How do you trigger this?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...