linux-kernel - Re: [PATCH] iio: adc: xilinx: check return value of xadc_write_adc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jan 2019 12:16:49 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Aditya Pakki <pakki001@....edu>
CC:     <kjlu@....edu>, Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Michal Simek <michal.simek@...inx.com>,
        Manish Narani <manish.narani@...inx.com>,
        <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: xilinx: check return value of
 xadc_write_adc_reg

On 27. 12. 18 20:54, Aditya Pakki wrote:
> In function xadc_probe, xadc_write_adc_reg can return an error value
> when write fails. The fix checks for the return value consistent with
> other invocations of the latter function.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
>  drivers/iio/adc/xilinx-xadc-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
> index 3f6be5ac049a..b13c61539d46 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1273,8 +1273,10 @@ static int xadc_probe(struct platform_device *pdev)
>  			xadc->threshold[i] = 0xffff;
>  		else
>  			xadc->threshold[i] = 0;
> -		xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(i),
> +		ret = xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(i),
>  			xadc->threshold[i]);
> +		if (ret)
> +			goto err_free_irq;
>  	}
>  
>  	/* Go to non-buffered mode */
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal