linux-kernel - Re: [PATCH 4/4] kbuild: make LINUX_VERSION_CODE in <linux/version.h> more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAThpS+W_aUr3V9EN7V5A67mjvhOWAU1XZGDvS4ByBfeVg@mail.gmail.com>
Date:   Thu, 3 Jan 2019 10:14:30 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] kbuild: make LINUX_VERSION_CODE in <linux/version.h>
 more readable

On Mon, Dec 31, 2018 at 5:25 PM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> Makefile does not need to calculate LINUX_VERSION_CODE.
> Let's leave it to the preprocessor.
>
> This commit changes include/generated/uapi/linux/version.h as follows:
>
> Before:
>
>   #define LINUX_VERSION_CODE 267264
>   #define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
>
> After:
>
>   #define LINUX_VERSION_CODE KERNEL_VERSION(4, 20, 0)
>   #define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
>
> The latter is more human-readable in my opinion.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>


I retract this patch
because it would cause a build error.




> ---
>
>  Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 437d603..1ebf5ed 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1131,8 +1131,7 @@ define filechk_utsrelease.h
>  endef
>
>  define filechk_version.h
> -       echo \#define LINUX_VERSION_CODE $(shell                         \
> -       expr $(VERSION) \* 65536 + 0$(PATCHLEVEL) \* 256 + 0$(SUBLEVEL)); \
> +       echo '#define LINUX_VERSION_CODE KERNEL_VERSION($(VERSION), $(PATCHLEVEL), $(SUBLEVEL))'; \
>         echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))'
>  endef
>
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada