linux-kernel - Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9iUCOSP+UMW0q0jW_SBgF-5sE-YtYEOaVwON6ndwHeOM7VBQ@mail.gmail.com>
Date:   Thu, 3 Jan 2019 14:57:40 +0000
From:   Sinan Kaya <Okaya@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        ACPI Devel Mailing List <linux-acpi@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Faiz Abbas <faiz_abbas@...com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Ludovic Barre <ludovic.barre@...com>,
        Arnd Bergmann <arnd@...db.de>,
        Alex Smith <alex.smith@...tec.com>,
        Chris Brandt <chris.brandt@...esas.com>,
        "open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." 
        <linux-mmc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit

On Thu, Jan 3, 2019 at 2:50 PM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> On 2/01/19 8:10 PM, Sinan Kaya wrote:
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> > on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> This driver does not rely on IOSF_MBI
>

X86 version does.

select IOSF_MBI if X86


> You wrote on the other email QCOM doesn't use PCI but here you are making
> them depend on it.  Please explain.
>

I matched the behavior before my change. This code wouldn't be
available without PCI and ACPI on previous kernel versions and left
kconfig cleanup as another exercise for some other day.

> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@...nel.org>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index e26b8145efb3..1b9401fe94c0 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
> >
> >  config MMC_SDHCI_ACPI
> >       tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> > -     depends on MMC_SDHCI && ACPI
> > +     depends on MMC_SDHCI && ACPI && PCI
> >       select IOSF_MBI if X86
> >       help
> >         This selects support for ACPI enumerated SDHCI controllers,
> >
>