linux-kernel - Re: [PATCH v2 0/2] USB Storage quirk for SMI SM3350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1901031006220.1460-100000@iolanthe.rowland.org>
Date:   Thu, 3 Jan 2019 10:06:43 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Icenowy Zheng <icenowy@...c.io>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>,
        <usb-storage@...ts.one-eyed-alien.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] USB Storage quirk for SMI SM3350

On Thu, 3 Jan 2019, Icenowy Zheng wrote:

> SMI SM3350 UFS-USB bridge controller cannot handle REQUEST SENSE command
> with long sense (96-bytes) well, and will even trap the controller into
> a state that refuses to do read/write command.
> 
> Currently Linux uncondintionally set US_FL_SANE_SENSE for devices
> claiming SPC3+, which makes simply add US_FL_BAD_SENSE for SM3350 fail
> (as it claims SPC4).
> 
> Fix this conflicting quirk issue, and add the quirk for SM3350.
> 
> Icenowy Zheng (2):
>   USB: storage: don't insert sane sense for SPC3+ when bad sense
>     specified
>   USB: storage: add quirk for SMI SM3350
> 
>  drivers/usb/storage/scsiglue.c     |  8 ++++++--
>  drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
>  2 files changed, 18 insertions(+), 2 deletions(-)

For both patches:

Acked-by: Alan Stern <stern@...land.harvard.edu>