[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0hwhuerPoizdYjqNkdymxubOweZ3JhPiXRUcrNtByz_=Q@mail.gmail.com>
Date: Thu, 3 Jan 2019 18:22:56 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Rob Herring <robh@...nel.org>,
Andrzej Hajda <a.hajda@...sung.com>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
javierm@...hat.com,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Russell King - ARM Linux <linux@...linux.org.uk>,
Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*()
On Thu, Jan 3, 2019 at 5:12 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Quoting Rafael J. Wysocki (2019-01-03 01:40:26)
> > On Wed, Jan 2, 2019 at 7:51 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > > @@ -130,6 +125,22 @@ int platform_get_irq(struct platform_device *dev, unsigned int num)
> > > return r ? r->start : -ENXIO;
> > > #endif
> > > }
> > > +
> > > +/**
> > > + * platform_get_irq - get an IRQ for a device
> > > + * @dev: platform device
> > > + * @num: IRQ number index
> > > + */
> > > +int platform_get_irq(struct platform_device *dev, unsigned int num)
> > > +{
> > > + int ret;
> > > +
> > > + ret = __platform_get_irq(dev, num);
> > > + if (ret < 0 && ret != -EPROBE_DEFER)
> > > + dev_err(&dev->dev, "IRQ index %u not found\n", num);
> >
> > Why don't you log the error code too?
> >
>
> I don't see much benefit to seeing -ENXIO or -EINVAL printed here, so I
> left out the error code.
OK, so the value of the message is to tell the user that some driver
asked for an invalid IRQ, right?
Powered by blists - more mailing lists