linux-kernel - Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190103172738.GQ16508@imbe.wolfsonmicro.main>
Date:   Thu, 3 Jan 2019 17:27:38 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
CC:     <mazziesaccount@...il.com>, <broonie@...nel.org>,
        <gregkh@...uxfoundation.org>, <rafael@...nel.org>,
        <geert@...ux-m68k.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type
 settings

On Thu, Dec 27, 2018 at 10:44:43AM +0200, Matti Vaittinen wrote:
> Do not return error if irq-type setting is requested for
> controlloer which does not support this. This is how
> regmap-irq has previously handled the undupported type
> settings and existing drivers seem to be upset if failure
> is now reported.
> 
> Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add level-irq support")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> ---
> 
> Geert reported that 1c2928e3e321 breaks da9063-rtc on the Renesas
> Koelsch board:
> 
> https://lore.kernel.org/lkml/20181227075648.GB2461@localhost.localdomain/T/#m194616cc88d7b4c2a78f7ce07907608fdb64a092
> 
> Geert, do you know if anyone vould to test this?
> 

Bit late since its already been applied but this patch fixes the
issues I had.

Thanks,
Charles