[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0jj13UgkM+7ad8-17W_4cdOJw61FMyvshBAcybzaiea5A@mail.gmail.com>
Date: Thu, 3 Jan 2019 18:38:55 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Rob Herring <robh@...nel.org>,
Andrzej Hajda <a.hajda@...sung.com>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
javierm@...hat.com,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Russell King - ARM Linux <linux@...linux.org.uk>,
Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v3] driver core: platform: Add an error message to platform_get_irq*()
On Thu, Jan 3, 2019 at 6:25 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Quoting Rafael J. Wysocki (2019-01-03 09:22:56)
> > On Thu, Jan 3, 2019 at 5:12 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > >
> > > I don't see much benefit to seeing -ENXIO or -EINVAL printed here, so I
> > > left out the error code.
> >
> > OK, so the value of the message is to tell the user that some driver
> > asked for an invalid IRQ, right?
>
> Yes.
OK
This can help to reduce code duplication a bit, so
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
for the v3.
Powered by blists - more mailing lists