linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jan 2019 15:42:49 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Rohit kumar <rohitkr@...eaurora.org>
Cc:     dianders@...omium.org, andy.gross@...aro.org,
        david.brown@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, plai@...eaurora.org,
        bgoswami@...eaurora.org, srinivas.kandagatla@...aro.org,
        linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Add ADSP reserve-memory
 nodes

On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote:

> Add memory nodes required for remoteproc q6v5_adsp pil.
> 

This range doesn't match the documented memory map. I would prefer to
see a "Specify all PIL regions as defined in V10" or similar.

Regards,
Bjorn

> Signed-off-by: Rohit kumar <rohitkr@...eaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 23a253b..c0a012f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -88,6 +88,11 @@
>  			reg = <0 0x86200000 0 0x2d00000>;
>  			no-map;
>  		};
> +
> +		pil_adsp_mem: memory@...00000 {
> +			reg = <0 0x8b100000 0 0x1a00000>;
> +			no-map;
> +		};
>  	};
>  
>  	cpus {
> -- 
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>