linux-kernel - Re: [PATCH V1] i2c: tegra: Fix Maximum transfer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201901031213.PpP4Dc7b%fengguang.wu@intel.com>
Date:   Thu, 3 Jan 2019 12:47:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sowjanya Komatineni <skomatineni@...dia.com>
Cc:     kbuild-all@...org, thierry.reding@...il.com, jonathanh@...dia.com,
        talho@...dia.com, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Sowjanya Komatineni <skomatineni@...dia.com>
Subject: Re: [PATCH V1] i2c: tegra: Fix Maximum transfer size

Hi Sowjanya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on v4.20 next-20190102]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sowjanya-Komatineni/i2c-tegra-Fix-Maximum-transfer-size/20190103-082727
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-tegra.c:839:18: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     .max_read_len = 65536,
                     ^~~~~
   drivers/i2c/busses/i2c-tegra.c:840:19: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     .max_write_len = 65536,
                      ^~~~~
>> drivers/i2c/busses/i2c-tegra.c:854:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra_i2c_quirks,
               ^
   drivers/i2c/busses/i2c-tegra.c:868:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra_i2c_quirks,
               ^
   drivers/i2c/busses/i2c-tegra.c:882:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra_i2c_quirks,
               ^
   drivers/i2c/busses/i2c-tegra.c:896:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra_i2c_quirks,
               ^
   drivers/i2c/busses/i2c-tegra.c:910:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra_i2c_quirks,
               ^
   drivers/i2c/busses/i2c-tegra.c:924:12: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     .quirks = &tegra194_i2c_quirks,
               ^

vim +839 drivers/i2c/busses/i2c-tegra.c

   836	
   837	static const struct i2c_adapter_quirks tegra194_i2c_quirks = {
   838		.flags = I2C_AQ_NO_ZERO_LEN,
 > 839		.max_read_len = 65536,
   840		.max_write_len = 65536,
   841	};
   842	
   843	static const struct tegra_i2c_hw_feature tegra20_i2c_hw = {
   844		.has_continue_xfer_support = false,
   845		.has_per_pkt_xfer_complete_irq = false,
   846		.has_single_clk_source = false,
   847		.clk_divisor_hs_mode = 3,
   848		.clk_divisor_std_fast_mode = 0,
   849		.clk_divisor_fast_plus_mode = 0,
   850		.has_config_load_reg = false,
   851		.has_multi_master_mode = false,
   852		.has_slcg_override_reg = false,
   853		.has_mst_fifo = false,
 > 854		.quirks = &tegra_i2c_quirks,
   855	};
   856	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (67719 bytes)