linux-kernel - Re: [PATCH 1/2] xtensa: remove nargs from _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALxhOnhVKRC0faiQTNNeUP3rYtK7aUg1Sr758ScokrBnE55iHQ@mail.gmail.com>
Date:   Fri, 4 Jan 2019 11:44:13 +0530
From:   Firoz Khan <firoz.khan@...aro.org>
To:     Max Filippov <jcmvbkbc@...il.com>
Cc:     Chris Zankel <chris@...kel.net>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        linux-xtensa@...ux-xtensa.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

Hi Max,

On Fri, 4 Jan 2019 at 11:25, Max Filippov <jcmvbkbc@...il.com> wrote:
> On Thu, Jan 3, 2019 at 9:17 PM Firoz Khan <firoz.khan@...aro.org> wrote:
> > On Fri, 4 Jan 2019 at 08:28, Max Filippov <jcmvbkbc@...il.com> wrote:
> > > On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan <firoz.khan@...aro.org> wrote:
> > This was intentional as I was trying compile other one architecture with the
> > previous implementation, it was giving the error. So I modified without space
> > after comma.
>
> I have tested that presence or absence of space does not affect the build
> for xtensa, and normally we put space after a comma, so I've mentioned that.
>
> Since this script is anyway removed in the next patch of the series it doesn't
> really matter whether the spaces are present or not.

Yes, you are right, there is no effect in xtensa but if I'm right
there is a problem
in powerpc architecture (not remembering exactly which arch) with this space
after comma.

BTW, the script from all architecture will be removed and keep it in
scripts directory
is our plan. So to satisfy powerpc (again I'm not sure which arch) I
just did this
change.

Thanks for your feedback.

Firoz