[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8412ac64-cd6d-7390-87a1-24f5e7cdf87a@st.com>
Date: Fri, 4 Jan 2019 09:05:55 +0100
From: Pierre Yves MORDRET <pierre-yves.mordret@...com>
To: Aditya Pakki <pakki001@....edu>
CC: Alexandre Torgue <alexandre.torgue@...com>, <kjlu@....edu>,
<linux-kernel@...r.kernel.org>, Vinod Koul <vkoul@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
<dmaengine@...r.kernel.org>,
Dan Williams <dan.j.williams@...el.com>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] dmaengine: stm32-mdma: Add a check on read_u32_array
Hello
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>
Regards
On 12/28/18 8:26 PM, Aditya Pakki wrote:
> In stm32_mdma_probe, after reading the property "st,ahb-addr-masks", the
> second call is not checked for failure. This time of check to time of use
> case of "count" error is sent upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
> drivers/dma/stm32-mdma.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 390e4cae0e1a..485dea177704 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1579,9 +1579,11 @@ static int stm32_mdma_probe(struct platform_device *pdev)
>
> dmadev->nr_channels = nr_channels;
> dmadev->nr_requests = nr_requests;
> - device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> + ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks",
> dmadev->ahb_addr_masks,
> count);
> + if (ret)
> + return ret;
> dmadev->nr_ahb_addr_masks = count;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
Powered by blists - more mailing lists