linux-kernel - Re: [PATCH] sched/fair: Remove unneeded prototype of capacity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190104091526.uxnw3bic6xydvbh6@queper01-lin>
Date:   Fri, 4 Jan 2019 09:15:28 +0000
From:   Quentin Perret <quentin.perret@....com>
To:     Valentin Schneider <valentin.schneider@....com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, morten.rasmussen@....com,
        Dietmar.Eggemann@....com
Subject: Re: [PATCH] sched/fair: Remove unneeded prototype of capacity_of()

Hi Valentin,

On Wednesday 02 Jan 2019 at 13:55:49 (+0000), Valentin Schneider wrote:
> The prototype of that function was already hoisted up in
> 
>   commit 3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
> 
> but that seems to have been missed.

Indeed, I missed that one :/

> Get rid of the extra prototype.
> 
> Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
> Signed-off-by: Valentin Schneider <valentin.schneider@....com>
> ---
>  kernel/sched/fair.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 6483834f1278..6d653947a829 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5083,7 +5083,6 @@ static inline void hrtick_update(struct rq *rq)
>  
>  #ifdef CONFIG_SMP
>  static inline unsigned long cpu_util(int cpu);
> -static unsigned long capacity_of(int cpu);
>  
>  static inline bool cpu_overutilized(int cpu)
>  {
> --
> 2.20.1

Acked-by: Quentin Perret <quentin.perret@....com>

Thanks for cleaning this up,
Quentin