linux-kernel - Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190104103015.GA3738@red-moon>
Date:   Fri, 4 Jan 2019 10:30:25 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     bhelgaas@...gle.com, khilman@...libre.com,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: amlogic: fix build failure due to missing
 linux/gpio/consumer.h header

On Fri, Jan 04, 2019 at 09:08:37AM +0000, Corentin Labbe wrote:
> When building on x86, I got the following build failure:

Hi,

what tree are you testing on and which config ?

Thanks,
Lorenzo

> drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’:
> drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
>   gpiod_set_value_cansleep(mp->reset_gpio, 0);
>   ^~~~~~~~~~~~~~~~~~~~~~~~
>   gpio_set_value_cansleep
> drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’:
> drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration]
>   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>                    ^~~~~~~~~~~~~~
>                    devm_gpio_free
> drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’?
>   mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>                                                 ^~~~~~~~~~~~~
>                                                 GPIOF_INIT_LOW
> 
> This is due to the missing linux/gpio/consumer.h header
> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  drivers/pci/controller/dwc/pci-meson.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c
> index 241ebe0c4505..e35e9eaa50ee 100644
> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -8,6 +8,7 @@
>  
>  #include <linux/clk.h>
>  #include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/pci.h>
> -- 
> 2.19.2
>