linux-kernel - Re: [PATCH] irqchip: madera: Drop GPIO includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e99200a-7a4f-17e7-aec6-a84dfed268ea@opensource.cirrus.com>
Date:   Fri, 4 Jan 2019 13:29:28 +0000
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <marc.zyngier@....com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip: madera: Drop GPIO includes

On 03/01/19 10:26, Linus Walleij wrote:
> This irqchip does not use anything GPIO-related so drop
> the GPIO includes.
> 

An older version did some stuff with GPIOs but when that code was removed
this include obviously was forgotten.

> Cc: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>   drivers/irqchip/irq-madera.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-madera.c b/drivers/irqchip/irq-madera.c
> index e9256dee1a45..8b81271c823c 100644
> --- a/drivers/irqchip/irq-madera.c
> +++ b/drivers/irqchip/irq-madera.c
> @@ -7,7 +7,6 @@
>    */
>   
>   #include <linux/module.h>
> -#include <linux/gpio.h>
>   #include <linux/interrupt.h>
>   #include <linux/irq.h>
>   #include <linux/irqdomain.h>
> @@ -16,7 +15,6 @@
>   #include <linux/slab.h>
>   #include <linux/of.h>
>   #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>   #include <linux/of_irq.h>
>   #include <linux/irqchip/irq-madera.h>
>   #include <linux/mfd/madera/core.h>
> 

Acked-by: Richard Fitzgerald <rf@...nsource.cirrus.com>