linux-kernel - Re: [PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190104024449.GB17431@bogus>
Date:   Thu, 3 Jan 2019 20:44:49 -0600
From:   Rob Herring <robh@...nel.org>
To:     h00249924 <hutenghui@...wei.com>
Cc:     dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        suzhuangluan@...ilicon.com, kongfei@...ilicon.com,
        liyuequan@...ilicon.com, cash.qianli@...ilicon.com,
        huangli295@...ilicon.com, hantanglei@...wei.com,
        wangyoulin1@...ilicon.com, ninggaoyu@...ilicon.com,
        hanxiaolong3@...ilicon.com,
        Youlin Wang <wwx575822@...esmail.huawei.com>,
        John Stultz <john.stultz@...aro.org>,
        Wei Xu <xuwei5@...ilicon.com>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device

On Fri, Dec 28, 2018 at 02:36:23PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@...esmail.huawei.com>
> 
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> Signed-off-by: Youlin Wang <wwx575822@...esmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@...wei.com>
> Cc: Wei Xu <xuwei5@...ilicon.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index f432b0a..5223e36 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1122,5 +1122,19 @@
>  				};
>  			};
>  		};
> +
> +		asp_dmac: asp_dmac@...4B000 {

dma-controller@...4b000

> +			compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> +			reg = <0x0 0xe804b000 0x0 0x1000>;
> +			#dma-cells = <1>;
> +			dma-channels = <16>;
> +			dma-requests = <32>;
> +			dma-min-chan = <0>;
> +			dma-used-chans = <0xFFFE>;

Use lowercase hex.

But more importantly, as John mentioned, this and other properties 
aren't documented.

> +			dma-share;
> +			interrupts = <0 216 4>;
> +			interrupt-names = "asp_dma_irq";
> +			status = "ok";

Don't need this.

> +		};
>  	};
>  };
> -- 
> 1.9.1
>