linux-kernel - Re: [PATCH 1/2] xtensa: remove nargs from _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Jan 2019 18:58:30 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Firoz Khan <firoz.khan@...aro.org>
Cc:     Chris Zankel <chris@...kel.net>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        linux-xtensa@...ux-xtensa.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038@...ts.linaro.org, LKML <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        marcin.juszkiewicz@...aro.org
Subject: Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL

On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan <firoz.khan@...aro.org> wrote:
>
> The __SYSCALL macro's arguments are system call number,
> system call entry name and number of arguments for the
> system call.
>
> Argument- nargs in __SYSCALL(nr, entry, nargs) is neither
> calculated nor used anywhere. So it would be better to
> keep the implementaion as  __SYSCALL(nr, entry). This will
> unifies the implementation with some other architetures
> too.

Perhaps "This will help unify the implementation with other architectures"?

> Signed-off-by: Firoz Khan <firoz.khan@...aro.org>
> ---
>  arch/xtensa/kernel/syscall.c              | 2 +-
>  arch/xtensa/kernel/syscalls/syscalltbl.sh | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/xtensa/kernel/syscall.c b/arch/xtensa/kernel/syscall.c
> index 2c415fc..0665339 100644
> --- a/arch/xtensa/kernel/syscall.c
> +++ b/arch/xtensa/kernel/syscall.c
> @@ -31,7 +31,7 @@
>  syscall_t sys_call_table[__NR_syscalls] /* FIXME __cacheline_aligned */= {
>         [0 ... __NR_syscalls - 1] = (syscall_t)&sys_ni_syscall,
>
> -#define __SYSCALL(nr, entry, nargs)[nr] = (syscall_t)entry,
> +#define __SYSCALL(nr, entry)[nr] = (syscall_t)entry,
>  #include <asm/syscall_table.h>
>  #undef __SYSCALL
>  };
> diff --git a/arch/xtensa/kernel/syscalls/syscalltbl.sh b/arch/xtensa/kernel/syscalls/syscalltbl.sh
> index 85d78d9..904b8e6 100644
> --- a/arch/xtensa/kernel/syscalls/syscalltbl.sh
> +++ b/arch/xtensa/kernel/syscalls/syscalltbl.sh
> @@ -13,10 +13,10 @@ emit() {
>         t_entry="$3"
>
>         while [ $t_nxt -lt $t_nr ]; do
> -               printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}"
> +               printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}"

Please add space after the comma.

>                 t_nxt=$((t_nxt+1))
>         done
> -       printf "__SYSCALL(%s, %s, )\n" "${t_nxt}" "${t_entry}"
> +       printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}"

Ditto.

>  }
>
>  grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> --
> 1.9.1

With the above changes:
Acked-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max