linux-kernel - Re: [PATCH v2] nvme-pci: fix dbbuf_sq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190104180710.GA4642@infradead.org>
Date:   Fri, 4 Jan 2019 10:07:10 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     "Lulina (A)" <lina.lulina@...wei.com>
Cc:     "axboe@...nel.dk" <axboe@...nel.dk>, "hch@....de" <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v2] nvme-pci: fix dbbuf_sq_db point to freed memory

On Fri, Dec 21, 2018 at 01:07:25AM +0000, Lulina (A) wrote:
> The case is that nvme device support NVME_CTRL_OACS_DBBUF_SUPP, and
> return failed when the driver sent nvme_admin_dbbuf. The nvmeq->dbbuf_sq_db
> point to freed memory, as nvme_dbbuf_set is called after nvme_dbbuf_init.

But we never use those pointers in that state, do we?  Can you explain
the problem in a little more detail?