linux-kernel - Re: [PATCH fieldbus v6 1/6] fieldbus_dev: add Fieldbus Device subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201901050333.U97nsfmO%fengguang.wu@intel.com>
Date:   Sat, 5 Jan 2019 03:32:18 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     kbuild-all@...org, svendev@...x.com, robh+dt@...nel.org,
        linus.walleij@...aro.org, lee.jones@...aro.org,
        mark.rutland@....com, afaerber@...e.de, treding@...dia.com,
        david@...hnology.com, noralf@...nnes.org, johan@...nel.org,
        monstr@...str.eu, michal.vokac@...ft.com, arnd@...db.de,
        gregkh@...uxfoundation.org, john.garry@...wei.com,
        geert+renesas@...der.be, robin.murphy@....com,
        paul.gortmaker@...driver.com,
        sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
        stuyoder@...il.com, maxime.ripard@...tlin.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH fieldbus v6 1/6] fieldbus_dev: add Fieldbus Device
 subsystem.

Hi Sven,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20]
[cannot apply to next-20190103]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sven-Van-Asbroeck/Add-Fieldbus-subsystem-support-HMS-Profinet-card/20190104-123600
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/fieldbus/dev_core.c: In function 'read_area_size_show':
>> drivers/fieldbus/dev_core.c:83:24: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=]
     return sprintf(buf, "%d\n", fb->read_area_sz);
                          ~^     ~~~~~~~~~~~~~~~~
                          %ld
   drivers/fieldbus/dev_core.c: In function 'write_area_size_show':
   drivers/fieldbus/dev_core.c:92:24: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=]
     return sprintf(buf, "%d\n", fb->write_area_sz);
                          ~^     ~~~~~~~~~~~~~~~~~
                          %ld

vim +83 drivers/fieldbus/dev_core.c

    77	
    78	static ssize_t read_area_size_show(struct device *dev,
    79				struct device_attribute *attr, char *buf)
    80	{
    81		struct fieldbus_dev *fb = dev_get_drvdata(dev);
    82	
  > 83		return sprintf(buf, "%d\n", fb->read_area_sz);
    84	}
    85	static DEVICE_ATTR_RO(read_area_size);
    86	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (67229 bytes)