linux-kernel - Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190104.125116.1758539198737883869.davem@davemloft.net>
Date:   Fri, 04 Jan 2019 12:51:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     peng.hao2@....com.cn
Cc:     qiang.zhao@....com, leoyang.li@....com,
        linux-kernel@...r.kernel.org, wen.yang99@....com.cn,
        julia.lawall@...6.fr, netdev@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of
 ucc_of_parse_tdm

From: Peng Hao <peng.hao2@....com.cn>
Date: Thu, 3 Jan 2019 01:09:53 +0800

> From: Wen Yang <wen.yang99@....com.cn>
> 
> Currently there are some issues with the ucc_of_parse_tdm function:
> 1, a possible null pointer dereference in ucc_of_parse_tdm,
> detected by the semantic patch deref_null.cocci,
> with the following warning:
> drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced.
> 2, dev gets modified, so in any case that devm_iounmap() will fail
> even when the new pdev is valid, because the iomap was done with a
>  different pdev.
> 3, there is no driver bind with the "fsl,t1040-qe-si" or
> "fsl,t1040-qe-siram" device. So allocating resources using devm_*()
> with these devices won't provide a cleanup path for these resources
> when the caller fails.
> 
> This patch fixes them.
> 
> Suggested-by: Li Yang <leoyang.li@....com>
> Suggested-by: Christophe LEROY <christophe.leroy@....fr>
> Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> Reviewed-by: Peng Hao <peng.hao2@....com.cn>

Applied, thanks.