linux-kernel - Re: [PATCH] qcom-scm: Include <linux/err.h> header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190104211537.GA19545@roeck-us.net>
Date:   Fri, 4 Jan 2019 13:15:37 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Fabio Estevam <festevam@...il.com>
Cc:     robdclark@...il.com, jonathan@...ek.ca,
        dri-devel@...ts.freedesktop.org, bjorn.andersson@...aro.org,
        andy.gross@...aro.org, shawnguo@...nel.org, cphealy@...il.com,
        linux-kernel@...r.kernel.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] qcom-scm: Include <linux/err.h> header

On Wed, Dec 26, 2018 at 10:06:19AM -0200, Fabio Estevam wrote:
> Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> the DRM_MSM symbol can be selected by SOC_IMX5 causing the following
> error when building imx_v6_v7_defconfig:
> 
> In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
> ../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
> ../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
>   return -ENODEV;
> 
> Include the <linux/err.h> header file to fix this problem.
> 
> Reported-by: kernelci.org bot <bot@...nelci.org>
> Fixes: e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> Signed-off-by: Fabio Estevam <festevam@...il.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Tested-by: Guenter Roeck <linux@...ck-us.net>

Still broken upstream, and the commit window is about to close.
Any chance to send this patch upstream anytime soon ?

Guenter

> ---
>  include/linux/qcom_scm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..ce5a476fd733 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -13,6 +13,7 @@
>  #ifndef __QCOM_SCM_H
>  #define __QCOM_SCM_H
>  
> +#include <linux/err.h>
>  #include <linux/types.h>
>  #include <linux/cpumask.h>
>