linux-kernel - Re: [PATCH] drivers: platform: goldfish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Jan 2019 15:44:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     rkir@...gle.com
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, Roman Kiryanov <rkir@...gle.com>
Subject: Re: [PATCH] drivers: platform: goldfish_sync: add a driver

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20 next-20190103]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/rkir-google-com/drivers-platform-goldfish_sync-add-a-driver/20190105-123342
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> drivers/platform/goldfish/goldfish_sync.c:807:34: error: array type has incomplete element type 'struct of_device_id'
    static const struct of_device_id goldfish_sync_of_match[] = {
                                     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/platform/goldfish/goldfish_sync.c:808:4: error: field name not in record or union initializer
     { .compatible = "google,goldfish-sync", },
       ^
   drivers/platform/goldfish/goldfish_sync.c:808:4: note: (near initialization for 'goldfish_sync_of_match')
>> drivers/platform/goldfish/goldfish_sync.c:813:36: error: array type has incomplete element type 'struct acpi_device_id'
    static const struct acpi_device_id goldfish_sync_acpi_match[] = {
                                       ^~~~~~~~~~~~~~~~~~~~~~~~

vim +807 drivers/platform/goldfish/goldfish_sync.c

   806	
 > 807	static const struct of_device_id goldfish_sync_of_match[] = {
 > 808		{ .compatible = "google,goldfish-sync", },
   809		{},
   810	};
   811	MODULE_DEVICE_TABLE(of, goldfish_sync_of_match);
   812	
 > 813	static const struct acpi_device_id goldfish_sync_acpi_match[] = {
   814		{ "GFSH0006", 0 },
   815		{ },
   816	};
   817	MODULE_DEVICE_TABLE(acpi, goldfish_sync_acpi_match);
   818	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (68388 bytes)