linux-kernel - Re: [PATCH] Display CHECK files like CC files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQA3Pvxyod2GD9tOkG9cSx32tmMN=dupgcjuHUw98LF7g@mail.gmail.com>
Date:   Sat, 5 Jan 2019 10:21:00 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Display CHECK files like CC files

Hi Matthew,

On Thu, Jan 3, 2019 at 12:41 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> When building with O= and C=1, this output looks weird:
>
>   CC      fs/file_table.o
>   CHECK   ../fs/file_table.c
>   CC      fs/open.o
>   CHECK   ../fs/open.c
>   CC      fs/super.o
>   CHECK   ../fs/super.c
>   CC      fs/read_write.o
>   CHECK   ../fs/read_write.c
>
> Use $@ like CC instead of $< to produce the same output for both CHECK and CC.
>
> Signed-off-by: Matthew Wilcox <willy@...radead.org>
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index fd03d60f6c5a..f36b03396d9a 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -74,10 +74,10 @@ __build: $(if $(KBUILD_BUILTIN),$(builtin-target) $(lib-target) $(extra-y)) \
>
>  # Linus' kernel sanity checking tool
>  ifeq ($(KBUILD_CHECKSRC),1)
> -  quiet_cmd_checksrc       = CHECK   $<
> +  quiet_cmd_checksrc       = CHECK   $@
>          cmd_checksrc       = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
>  else ifeq ($(KBUILD_CHECKSRC),2)
> -  quiet_cmd_force_checksrc = CHECK   $<
> +  quiet_cmd_force_checksrc = CHECK   $@
>          cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
>  endif


IMHO, $@ is also a bit weird
since Sparse does not produce objects at all.


What I can suggest is like follows:

quiet_cmd_checksrc       = CHECK   $(patsubst $(srctree)/%,%,$<)



-- 
Best Regards
Masahiro Yamada