linux-kernel - Re: [PATCH V2] usbcore: Select only first configuration for non-UAC3 compliant devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABqErrEyF0Fr57gk12_XNNhLdQX0A9b9OPyGeVfGVh1dvHhRrw@mail.gmail.com>
Date:   Sun, 6 Jan 2019 09:02:05 +1100
From:   Con Kolivas <kernel@...ivas.org>
To:     "Gopal, Saranya" <saranya.gopal@...el.com>
Cc:     gregkh@...uxfoundation.org,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...a-project.org, linux-usb@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.de>, felipe.balbi@...ux.intel.com
Subject: Re: [PATCH V2] usbcore: Select only first configuration for non-UAC3
 compliant devices

Hi Saranya

On Sun, 6 Jan 2019 at 04:41, <saranya.gopal@...el.com> wrote:
>
> From: Saranya Gopal <saranya.gopal@...el.com>
>
> In most of the UAC1 and UAC2 audio devices, the first
> configuration is most often the best configuration.
> However, with recent patch to support UAC3 configuration,
> second configuration was unintentionally chosen for
> some of the UAC1/2 devices that had more than one
> configuration. This was because of the existing check
> after the audio config check which selected any config
> which had a non-vendor class. This patch fixes this issue.
>
> Fixes: f13912d3f014 ("usbcore: Select UAC3 configuration for audio if present")
> Reported-by: Con Kolivas <kernel@...ivas.org>
> Signed-off-by: Saranya Gopal <saranya.gopal@...el.com>>

I can confirm the above patch fixes my problem.
Tested-by: Con Kolivas <kernel@...ivas.org>

Thanks!
Con