linux-kernel - Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6406c9c-d095-6c9b-55af-0b2fd05c06bb@lwfinger.net>
Date:   Fri, 4 Jan 2019 20:44:39 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Bernd Edlinger <bernd.edlinger@...mail.de>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

On 1/4/19 6:48 AM, Bernd Edlinger wrote:
> This appears to trigger a firmware bug and causes severe
> problems with rtl8723ae PCI devices.
> 
> When the power save mode is activated for longer periods
> of time the firmware stops to receive any packets.
> 
> This problem was exposed by commit 873ffe154ae0 ("rtlwifi:
> Fix logic error in enter/exit power-save mode").
> 
> Previously the power save mode was only active rarely and
> only for a short time so that the problem was not noticeable.
> 
> Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de>
> ---

While the Realtek firmware group has a chance to look for a bug, I would like 
you to perform a couple of tests on the original code.

The driver has three module parameters that affect power save. The 'modinfo 
rtl8723ae' command lists them as

parm:   ips:Set to 0 to not use link power save (default 1) (bool)
parm:   swlps:Set to 1 to use SW control power save (default 0) (bool)
parm:   fwlps:Set to 1 to use FW control power save (default 1) (bool)

If you were to load rtl8723ae with 'ips=0', does it still fail?
If you were to load the driver with 'swlps=1 fwlps=0', does it still fail?

Thanks for debugging this problem.

Larry