[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190106172613.10913-1-pakki001@umn.edu>
Date: Sun, 6 Jan 2019 11:26:12 -0600
From: Aditya Pakki <pakki001@....edu>
To: pakki001@....edu
Cc: kjlu@....edu, Matt Mackall <mpm@...enic.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Michael S. Tsirkin" <mst@...hat.com>, Michael Buesch <m@...s.ch>,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [v2] hwrng: core: Fix missing check during driver release
devres_release can return -ENOENT if the device is not freed. The fix
throws a warning consistent with other invocations.
Signed-off-by: Aditya Pakki <pakki001@....edu>
---
drivers/char/hw_random/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 95be7228f327..1b05da40626a 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -578,7 +578,8 @@ EXPORT_SYMBOL_GPL(devm_hwrng_register);
void devm_hwrng_unregister(struct device *dev, struct hwrng *rng)
{
- devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
+ WARN_ON(devres_release(dev, devm_hwrng_release,
+ devm_hwrng_match, rng));
}
EXPORT_SYMBOL_GPL(devm_hwrng_unregister);
--
2.17.1
Powered by blists - more mailing lists