linux-kernel - Re: [PATCH v2] staging: wilc1000: fix cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=P++DRiM8Rb8vg9hBJ-N2uhfL0Rrj+njYwgZW80yQZ4jQH4g@mail.gmail.com>
Date:   Sun, 6 Jan 2019 08:18:53 +0100
From:   Július Milan <jmilan.dev@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-wireless@...r.kernel.org, gregkh@...uxfoundation.org,
        ajay.kathat@...rochip.com, adham.abozaeid@...rochip.com
Subject: Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

Thank you for your review Larry

> Before you send V3

Oh, v3 was already sent a few moments before your message.

> Before you send V3, are you sure this is the correct fix? As "frame_type" is
> input as u16, it seems to me that the frame_type member of struct wilc_reg_frame
> should be __le16, not __le32.

Yes, I am confident about it.
The frame_type member of struct wilc_reg_frame contains in some cases
32 bit value
as you can see in function wilc_wlan_cfg_set_wid.
Cast to 32 bits is also safe, due to resultant endianness.

Julius