linux-kernel - Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190107161906.GC2292@kroah.com>
Date:   Mon, 7 Jan 2019 17:19:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ben Dooks <ben-linux@...ff.org>
Cc:     stern@...land.harvard.edu, linux-usb@...r.kernel.org,
        linux-kernel@...ts.codethink.co.uk, linux-kernel@...r.kernel.org,
        Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: Re: [PATCH] USB: host: ehci: allow tine of highspeed nak-count

On Wed, Nov 14, 2018 at 05:13:15PM +0000, Ben Dooks wrote:
> From: Ben Dooks <ben.dooks@...ethink.co.uk>
> 
> At least some systems benefit with less scheduling if the NAK count
> value is set higher than the default 4. For instance a Tegra3 with
> an SMSC9512 showed less interrupt load when this was changed to 14.
> 
> To allow the changing of this value, add a sysfs node to each of
> the controllers to allow run-time changing.

That's going to be a pain, why can you not just figure this out at
runtime and adjust it that way?

Also, you can't add a sysfs file and not also add a Documentation/API/
update :(

Can you fix this up to work without needing manual adjustments?

thanks,

greg k-h