linux-kernel - Re: [PATCH v5 08/15] KVM: s390: add the GIB and its related life-cyle functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1ef84b5f-179a-21e2-6ac2-b49f4c3ae5c3@linux.ibm.com>
Date:   Mon, 7 Jan 2019 17:25:05 +0100
From:   Michael Mueller <mimu@...ux.ibm.com>
To:     pmorel@...ux.ibm.com, KVM Mailing List <kvm@...r.kernel.org>
Cc:     Linux-S390 Mailing List <linux-s390@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        kvm390-list@...maker.boeblingen.de.ibm.com,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH v5 08/15] KVM: s390: add the GIB and its related life-cyle
 functions



On 03.01.19 10:49, Pierre Morel wrote:
> On 19/12/2018 20:17, Michael Mueller wrote:
>> The Guest Information Block (GIB) links the GISA of all guests
>> that have adapter interrupts pending. These interrupts cannot be
>> delivered because no vcpu of these guests is currently running in
>> SIE context. Instead, a GIB alert is issued on the host to schedule
>> these guests to run.
> 
> IMHO "Instead" is not exact.
> The GIB alert is always issued on adapter interrupt if IAM is set even 
> if the guest is running in SIE context.
> 
> I would prefer to rephrase to something like:
> "If enabled, a GIB alert is issued on the host..." ?

I agree.

> 
> 
> Reviewed-by: Pierre Morel<pmorel@...ux.ibm.com>
> 
> 
>>
>> This mechanism allows to process adapter interrupts for currently
>> not running guests.
>>
>> The GIB is created during host initialization and associated with
>> the Adapter Interruption Facility in case an Adapter Interruption
>> Virtualization Facility is available.
>>
>> The GIB initialization and thus the activation of the related code
>> will be done in an upcoming patch of this series.
>>
>> Signed-off-by: Michael Mueller <mimu@...ux.ibm.com>
>> Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>
>> ---
>>   arch/s390/include/asm/kvm_host.h | 10 +++++++++